-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Fix Webdriver BiDi events duplication #56803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foolip
approved these changes
Dec 17, 2025
foolip
approved these changes
Dec 17, 2025
7f8075a to
a17f552
Compare
…okens and event filtering.
a17f552 to
70f2816
Compare
70f2816 to
424d75a
Compare
4feb122 to
ea356a2
Compare
ea356a2 to
9184684
Compare
…y moving event listener registration to `setup` and using an instance variable for async exceptions.
infrastructure/testdriver/bidi/subscription.html test
foolip
reviewed
Jan 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #56985.
The events were duplicated, as the same Webdriver BiDi session has multiple event processors, causing testdriver.js notified about the same event several times. Fixed by setting up events forwarding only on test setup.
Failure example: https://github.com/web-platform-tests/wpt/pull/56779/checks?check_run_id=58288772050